Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): use event-capturing mode when enable component highlighter #302

Merged
merged 4 commits into from Apr 2, 2024

Conversation

xuzuodong
Copy link
Contributor

Resolves #301

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 4fc9356
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66066896fb90160009cfa0fb

@webfansplz
Copy link
Member

The changes will cause the use case to fail.

iShot_2024-03-29_12 42 56

We should find another way to handle it.

@xuzuodong
Copy link
Contributor Author

After some investigating at your previous work, I believe it should be handled correctly now.

录屏2024-03-29 15 07 28

@webfansplz webfansplz changed the title fix: when inspecting an element, clicking on the green rectangle caus… fix(kit): use event-capturing mode when enable component highlighter Apr 2, 2024
@webfansplz webfansplz merged commit 0f410e1 into vuejs:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When inspecting an component, clicking on the green rectangle causes the event to propagate downwards
2 participants