Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): auto scroll to component tree after inspected #308

Merged
merged 1 commit into from Apr 16, 2024

Conversation

JianJroh
Copy link
Contributor

@JianJroh JianJroh commented Apr 2, 2024

Before After
EqzrBQLoV9 EZVsSgWYdd

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit af8db5c
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/6614f9c829676f0008b1350d

@JianJroh JianJroh force-pushed the feat/auto-scroll-to-component-tree branch from 4063453 to af8db5c Compare April 9, 2024 08:18
@xuzuodong
Copy link
Contributor

Would it be more natural to first check if the active element is already visible in viewport, and in such case, scrolling is considered unnecessary and avoid triggering scrolling? As I implemented here

@JianJroh
Copy link
Contributor Author

JianJroh commented Apr 12, 2024

Would it be more natural to first check if the active element is already visible in viewport, and in such case, scrolling is considered unnecessary and avoid triggering scrolling? As I implemented here

I think it's necessary to scroll the target component into center of tree view even if it is already visible.

  • Make sure developer can easily check the parent and children of the target component
  • Keep the UI consistent after each inspected

@webfansplz webfansplz merged commit 6ab1abc into vuejs:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants