Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): unregister app instance when instance is unmounted #340

Merged
merged 4 commits into from Apr 22, 2024
Merged

fix(kit): unregister app instance when instance is unmounted #340

merged 4 commits into from Apr 22, 2024

Conversation

Azurewarth0920
Copy link
Collaborator

Fix: #333

  • Fix the behavior of unregistering app instance when an instance is unmounted.
  • Fix wrongly unregistering devtoolHook.
  • Filter instance on normalizeRouterInfo.

@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited

✅ Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit c4ef0d0
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/661e17f49cb91900081c1d73

@webfansplz
Copy link
Member

Can we add test cases for this? 🙏

@webfansplz webfansplz changed the title fix(kit): Unregister app instance when instance is unmounted fix(kit): unregister app instance when instance is unmounted Apr 22, 2024
@webfansplz
Copy link
Member

Can we add test cases for this? 🙏

Great work! We can merge it for now and add the test cases later.

@webfansplz webfansplz merged commit 5da5a6c into vuejs:main Apr 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfansplz webfansplz webfansplz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

应该识别页面上所有的 app 实例
2 participants
@Azurewarth0920 @webfansplz