fix: remove eslint internal traverser (#910)

vuejs · Jun 24, 2019 · 082c03d · 082c03d
1 parent 4ff3c8a
commit 082c03d
Showing 1 changed file with 18 additions and 6 deletions.
diff --git a/lib/rules/order-in-components.js b/lib/rules/order-in-components.js
@@ -5,7 +5,7 @@
 'use strict'
 
 const utils = require('../utils')
-const Traverser = require('eslint/lib/util/traverser')
+const traverseNodes = require('vue-eslint-parser').AST.traverseNodes
 
 const defaultOrder = [
   'el',
@@ -93,9 +93,14 @@ const LOGICAL_OPERATORS = ['&&', '||']
  */
 function isNotSideEffectsNode (node, visitorKeys) {
   let result = true
-  new Traverser().traverse(node, {
+  const noSideEffectsNodes = new Set()
+  traverseNodes(node, {
     visitorKeys,
-    enter (node, parent) {
+    enterNode (node, parent) {
+      if (!result || noSideEffectsNodes.has(node)) {
+        return
+      }
+
       if (
         node.type === 'FunctionExpression' ||
         node.type === 'Identifier' ||
@@ -105,7 +110,14 @@ function isNotSideEffectsNode (node, visitorKeys) {
         node.type === 'TemplateElement'
       ) {
         // no side effects node
-        this.skip()
+        noSideEffectsNodes.add(node)
+        traverseNodes(node, {
+          visitorKeys,
+          enterNode (node) {
+            noSideEffectsNodes.add(node)
+          },
+          leaveNode () {}
+        })
       } else if (
         node.type !== 'Property' &&
         node.type !== 'ObjectExpression' &&
@@ -121,9 +133,9 @@ function isNotSideEffectsNode (node, visitorKeys) {
       ) {
         // Can not be sure that a node has no side effects
         result = false
-        this.break()
       }
-    }
+    },
+    leaveNode () {}
   })
   return result
 }