From 7cc41c99534457b2a1eaa8588b8076d8cb91bf38 Mon Sep 17 00:00:00 2001
From: Yosuke Ota <otameshiyo23@gmail.com>
Date: Sun, 7 Jun 2020 19:26:45 +0900
Subject: [PATCH] Add `vue/func-call-spacing` rule (#1201)

* Add `vue/func-call-spacing` rule

* fix

* fixed
---
 docs/rules/README.md                 |  1 +
 docs/rules/func-call-spacing.md      | 25 ++++++++
 lib/configs/no-layout-rules.js       |  1 +
 lib/index.js                         |  1 +
 lib/rules/func-call-spacing.js       | 11 ++++
 tests/lib/rules/func-call-spacing.js | 85 ++++++++++++++++++++++++++++
 6 files changed, 124 insertions(+)
 create mode 100644 docs/rules/func-call-spacing.md
 create mode 100644 lib/rules/func-call-spacing.js
 create mode 100644 tests/lib/rules/func-call-spacing.js

diff --git a/docs/rules/README.md b/docs/rules/README.md
index 261eed05c..1fe658682 100644
--- a/docs/rules/README.md
+++ b/docs/rules/README.md
@@ -322,6 +322,7 @@ The following rules extend the rules provided by ESLint itself and apply them to
 | [vue/dot-location](./dot-location.md) | enforce consistent newlines before and after dots | :wrench: |
 | [vue/dot-notation](./dot-notation.md) | enforce dot notation whenever possible | :wrench: |
 | [vue/eqeqeq](./eqeqeq.md) | require the use of `===` and `!==` | :wrench: |
+| [vue/func-call-spacing](./func-call-spacing.md) | require or disallow spacing between function identifiers and their invocations | :wrench: |
 | [vue/key-spacing](./key-spacing.md) | enforce consistent spacing between keys and values in object literal properties | :wrench: |
 | [vue/keyword-spacing](./keyword-spacing.md) | enforce consistent spacing before and after keywords | :wrench: |
 | [vue/max-len](./max-len.md) | enforce a maximum line length |  |
diff --git a/docs/rules/func-call-spacing.md b/docs/rules/func-call-spacing.md
new file mode 100644
index 000000000..41af5a45a
--- /dev/null
+++ b/docs/rules/func-call-spacing.md
@@ -0,0 +1,25 @@
+---
+pageClass: rule-details
+sidebarDepth: 0
+title: vue/func-call-spacing
+description: require or disallow spacing between function identifiers and their invocations
+---
+# vue/func-call-spacing
+> require or disallow spacing between function identifiers and their invocations
+
+- :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule.
+
+This rule is the same rule as core [func-call-spacing] rule but it applies to the expressions in `<template>`.
+
+## :books: Further reading
+
+- [func-call-spacing]
+
+[func-call-spacing]: https://eslint.org/docs/rules/func-call-spacing
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/func-call-spacing.js)
+- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/func-call-spacing.js)
+
+<sup>Taken with ❤️ [from ESLint core](https://eslint.org/docs/rules/func-call-spacing)</sup>
diff --git a/lib/configs/no-layout-rules.js b/lib/configs/no-layout-rules.js
index 4e4734e52..3d2cb5d30 100644
--- a/lib/configs/no-layout-rules.js
+++ b/lib/configs/no-layout-rules.js
@@ -13,6 +13,7 @@ module.exports = {
     'vue/comma-spacing': 'off',
     'vue/comma-style': 'off',
     'vue/dot-location': 'off',
+    'vue/func-call-spacing': 'off',
     'vue/html-closing-bracket-newline': 'off',
     'vue/html-closing-bracket-spacing': 'off',
     'vue/html-comment-content-newline': 'off',
diff --git a/lib/index.js b/lib/index.js
index 6a9462c7b..f962015c3 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -25,6 +25,7 @@ module.exports = {
     'dot-location': require('./rules/dot-location'),
     'dot-notation': require('./rules/dot-notation'),
     eqeqeq: require('./rules/eqeqeq'),
+    'func-call-spacing': require('./rules/func-call-spacing'),
     'html-closing-bracket-newline': require('./rules/html-closing-bracket-newline'),
     'html-closing-bracket-spacing': require('./rules/html-closing-bracket-spacing'),
     'html-comment-content-newline': require('./rules/html-comment-content-newline'),
diff --git a/lib/rules/func-call-spacing.js b/lib/rules/func-call-spacing.js
new file mode 100644
index 000000000..da076f9cb
--- /dev/null
+++ b/lib/rules/func-call-spacing.js
@@ -0,0 +1,11 @@
+/**
+ * @author Yosuke Ota
+ */
+'use strict'
+
+const { wrapCoreRule } = require('../utils')
+
+// eslint-disable-next-line no-invalid-meta, no-invalid-meta-docs-categories
+module.exports = wrapCoreRule(require('eslint/lib/rules/func-call-spacing'), {
+  skipDynamicArguments: true
+})
diff --git a/tests/lib/rules/func-call-spacing.js b/tests/lib/rules/func-call-spacing.js
new file mode 100644
index 000000000..93df1577c
--- /dev/null
+++ b/tests/lib/rules/func-call-spacing.js
@@ -0,0 +1,85 @@
+/**
+ * @author Yosuke Ota
+ */
+'use strict'
+
+const { RuleTester, CLIEngine } = require('eslint')
+const semver = require('semver')
+const rule = require('../../../lib/rules/func-call-spacing')
+
+const tester = new RuleTester({
+  parser: require.resolve('vue-eslint-parser'),
+  parserOptions: { ecmaVersion: 2020 }
+})
+
+tester.run('func-call-spacing', rule, {
+  valid: [
+    `
+    <template>
+      <div :foo="foo()" />
+    </template>
+    `,
+    {
+      code: `
+      <template>
+        <div :foo="foo ()" />
+      </template>
+      `,
+      options: ['always']
+    },
+    `
+    <template>
+      <div :[foo()]="value" />
+    </template>
+    `,
+    {
+      code: `
+      <template>
+        <div :[foo()]="value" />
+      </template>
+      `,
+      options: ['always']
+    }
+  ],
+  invalid: [
+    {
+      code: `
+      <template>
+        <div :foo="foo ()" />
+      </template>
+      `,
+      output: `
+      <template>
+        <div :foo="foo()" />
+      </template>
+      `,
+      errors: [
+        {
+          message: semver.lt(CLIEngine.version, '7.0.0')
+            ? 'Unexpected newline between function name and paren.'
+            : 'Unexpected whitespace between function name and paren.',
+          line: 3
+        }
+      ]
+    },
+    {
+      code: `
+      <template>
+        <div :foo="foo()" />
+      </template>
+      `,
+      options: ['always'],
+      output: `
+      <template>
+        <div :foo="foo ()" />
+      </template>
+      `,
+      errors: [
+        {
+          message: 'Missing space between function name and paren.',
+          line: 3
+        }
+      ]
+    }
+  ]
+})