Fix false positives for assignments in no-ref-as-operand rule (#1409)

vuejs · Jan 5, 2021 · d176d6b · d176d6b
1 parent c387fc3
commit d176d6b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rules/no-ref-as-operand.js b/lib/rules/no-ref-as-operand.js
@@ -131,8 +131,11 @@ module.exports = {
         reportIfRefWrapped(node)
       },
       // refValue+=1, refValue-=1, foo+=refValue, foo-=refValue
-      /** @param {Identifier} node */
+      /** @param {Identifier & {parent: AssignmentExpression}} node */
       'AssignmentExpression>Identifier'(node) {
+        if (node.parent.operator === '=' && node.parent.left !== node) {
+          return
+        }
         reportIfRefWrapped(node)
       },
       // refValue || other, refValue && other. ignore: other || refValue

diff --git a/tests/lib/rules/no-ref-as-operand.js b/tests/lib/rules/no-ref-as-operand.js
@@ -121,6 +121,16 @@ tester.run('no-ref-as-operand', rule, {
     const count = ref
     count++
     `,
+    `
+    import { ref } from 'vue'
+    const count = ref(0)
+    foo = count
+    `,
+    `
+    import { ref } from 'vue'
+    const count = ref(0)
+    const foo = count
+    `,
     {
       code: `
       <script>