Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: vue/html-button-has-type rule #1001

Merged
merged 8 commits into from Feb 5, 2021
Merged

Conversation

SanterreJo
Copy link
Contributor

No description provided.

@SanterreJo SanterreJo changed the title New: vue/html-button-has-type rule (fixes #894) New: vue/html-button-has-type rule Dec 8, 2019
@SanterreJo
Copy link
Contributor Author

This rule fixes #894

@Etheryte
Copy link

Thanks for putting in the hours to make this work. Can't wait to have it merged, would be insanely helpful on large codebases.

@seanogdev
Copy link

This would be great to get into the next version!

@mrleblanc101
Copy link

Almost a year, will this get merged ?

@ota-meshi
Copy link
Member

Sorry for not commenting for very long time.

I thought it would be better to implement a rule that checks the required attributes of every element, using something like component data, rather than creating a <button> specific rule, but now I found it difficult to implement this generic rule.

Could you update this PR to resolve the conflict?

# Conflicts:
#	docs/rules/README.md
#	lib/configs/recommended.js
#	lib/index.js
@SanterreJo
Copy link
Contributor Author

@ota-meshi
merge conflict is resolved

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants