Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list semver as a dependency #1023

Merged
merged 1 commit into from Dec 30, 2019
Merged

fix: list semver as a dependency #1023

merged 1 commit into from Dec 30, 2019

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Dec 30, 2019

Introduced in #841

Moves semver from devDependencies to dependencies since it's needed by two rules.

const { Range } = require('semver')

Ref yarnpkg/berry#654

@armano2 armano2 added bug dependencies Pull requests that update a dependency file labels Dec 30, 2019
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 5b7dd8a into vuejs:master Dec 30, 2019
@merceyz merceyz deleted the semver branch December 30, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants