Feature/support for fragments #1038
Merged
+294
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late-root implementation for Vue 2
ota-meshi
approved these changes
Feb 6, 2020
|
I think creating categories for Vue3 is a separate task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! After @sodatea 's tweet, I decided to try my first contribution to Vuejs project :) This PR is based on the previous implementation of
vue/valid-template-rootif you think that something is missing or should be changed I will try to do it as soon as possible!Add support for Vue 3 fragments.
Relates to:
#1035
Scope:
vue/valid-template-root: Remove a single root element check. New implementation checks two different cases:<template>does not havesrcattribute, it needs to contain at least one element<template>havesrcattribute it needs to be emptyvue/no-multiple-template-root: New rule-based on previousvue/valid-template-rootimplementation used to check if template contains single root element (implemented for Vue 2 backward compatibility)Clarification needed:
How can we differentiate "essential" rules for Vue 2 from the one for Vue 3? Currently
vue/no-multiple-template-rootis added toconfigs/essential.jsbut I'm not sure how to do it correctly to do not affect build for Vue 3.