Vue3 v-model API changes #1039
Merged
Vue3 v-model API changes #1039
+638
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments. Vue 2 compatibility rule
przemkow
force-pushed
the
RFC0005/replace-v-bind-sync-with-v-model-argument
branch
from
723ffab to
a1d0547
Compare
przemkow
force-pushed
the
RFC0005/replace-v-bind-sync-with-v-model-argument
branch
from
a1d0547 to
900f89e
Compare
przemkow
changed the title
ota-meshi
requested changes
Mar 5, 2020
… on Vue component
…ks if v-model has not allowed modifiers (Vue 2 backward compatibility)
przemkow
force-pushed
the
RFC0005/replace-v-bind-sync-with-v-model-argument
branch
from
900f89e to
009ff3e
Compare
ota-meshi
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suppor for
v-modelAPI changesv-model:argumentsyntax (replacement forv-bind.sync)v-model.customModifiersyntaxRelates to:
#1035
RFC0005
RFC0011
Scope:
vue/valid-v-model- modify rule implementation to do not report an error when:v-modelis used with an argument on Vue Component. (v-model:argumentsyntax)v-modelis used with custom modifiers on Vue Component. (v-model. customModifiersyntax)vue/no-v-model-argument- new rule which reports an error whenv-modelis used with an argument on Vue Component (Vue 2 backward compatibility rule, previously handled byvue/valid-v-model)vue/no-deprecated-v-bind-sync- new rule which reports an error when deprecated.syncmodifier is used onv-binddirective.vue/no-custom-modifiers-on-v-model- new rule which reports an error when v-model is used with custom modifiers on Vue Component (Vue 2 backward compatibility rule, previously handled by vue/valid-v-model)Clarification needed:
v-bind.sync="xxx").According to RFC it's not clear which option was selected for the final implementation. Testing that with
Vue 3.0.0-alpha.3it seems that spread onv-modelis currently not supported, nevertheless, it requires additional confirmation before merge.