feat(RFC0015): add no-deprecated-filter rule #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
approved these changes
Feb 19, 2020
|
Thank you for this PR. I think people rarely do bitwise operations on templates. So I don't think there is a problem, but if you strictly parse it, you need to work on adding options to "vue-eslint-parser". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
no-deprecated-filterruleRelates to:
#1035
RFC0015
Scope:
vue/no-deprecated-filter- This rule reports usage offilterssyntax removed in Vue.js 3.0.0+Clarification needed:
VFilterSequenceExpression. As Vue.js 3 is going to drop support for filters, are they any plans to drop support for that node in AST generated byvue-eslint-parser?It seems like a reasonable move as
{{ 0b0001 | 0b0010 }}in Vue.js 3 AST should be probably interpreted asBinaryExpression