Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Add vue/no-lifecycle-after-await rule #1067

Merged
merged 2 commits into from Mar 14, 2020
Merged

New: Add vue/no-lifecycle-after-await rule #1067

merged 2 commits into from Mar 14, 2020

Conversation

ota-meshi
Copy link
Member

This PR adds the vue/no-lifecycle-after-await rule.

The vue/no-lifecycle-after-await rule reports the lifecycle hooks after await expression.

ref #1035

@ota-meshi ota-meshi self-assigned this Mar 7, 2020
@ota-meshi ota-meshi mentioned this pull request Mar 7, 2020
Closed
75 tasks
@kazupon
Copy link
Member

kazupon commented Mar 7, 2020

LGTM!

@michalsnik
If you can review, I hope you would review this PR, please.
FYI: related
https://github.com/vuejs/eslint-plugin-vue/labels/Vue.js%203.x

@ota-meshi ota-meshi merged commit 3cc5ac0 into master Mar 14, 2020
@ota-meshi ota-meshi deleted the add-rule/no-lifecycle-after-await branch March 14, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ota-meshi ota-meshi

Labels
semver-major Vue.js 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ota-meshi @kazupon