Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add vue/require-v-if-inside-transition rule #1099

Merged
merged 1 commit into from Apr 21, 2020

Conversation

ota-meshi
Copy link
Member

This PR adds the vue/require-v-if-inside-transition rule.

This rule reports elements inside <transition> that do not control the display.

ref #1035

@ota-meshi ota-meshi self-assigned this Apr 16, 2020
@ota-meshi ota-meshi mentioned this pull request Apr 16, 2020
75 tasks
@ota-meshi ota-meshi merged commit 3e90a0c into master Apr 21, 2020
@ota-meshi ota-meshi deleted the add-rule/require-v-if-inside-transition branch April 21, 2020 08:17
@sodatea
Copy link
Member

sodatea commented Apr 22, 2020

Hmmm, now I feel a little bit regretful on the rule naming…
Now that v-show is also allowed, is require-v-if- the right name for it?

@ota-meshi
Copy link
Member Author

Hi @sodatea.

I also considered the name, but v-if is a very short name and it is easy to understand the meaning of "control the presence of the content". I couldn't think of a better name than this.
Do you have any good name ideas?

@sodatea
Copy link
Member

sodatea commented Apr 22, 2020

What about require-toggle-inside-transition? I'm really bad at naming things 😂

@ota-meshi
Copy link
Member Author

I think that's good naming! I like that name! I would like to change the rule name in the next release.
Thank you:smile:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants