Add vue/no-unregistered-components rule
#1114
Conversation
Also remove text about where rule is included
…r ingore patterns
- Correct rule categories (null) - Ignore `component :is="..."` component for well known HTML tags. - Ignore `component`, `suspense`, `teleport` as unknown components.
|
@ota-meshi I think all the concerns are now fixed, tests are passing locally but the CI is blocking for |
|
Seems like |
|
Ok I think I'm almost there, just missing the |
| usedComponentNodes.push({ node, name: node.value.value }) | ||
| }, | ||
| "VElement[name='template']" (rootNode) { | ||
| templateLocation = templateLocation || rootNode.loc.start |
There was a problem hiding this comment.
This variable is no longer needed.
There was a problem hiding this comment.
Please remove the templateLocation variable.
- Remove no longer needed variable. - Handle edge case where a component is registered using kebab-case but later on is used using PascalCase. e.g: registered as `foo-bar` and used as `FooBar` is not valid. - Handle edge case `<component is />`, where `node.value` would be `null`. See https://github.com/mysticatea/vue-eslint-parser/blob/master/docs/ast.md#vattribute - Add more tests to prove all these changes
|
@ota-meshi great insights into this, thanks for it. I've just pushed 7c3198c fixing (hopefully) all the new concerns. |
| usedComponentNodes.push({ node, name: node.value.value }) | ||
| }, | ||
| "VElement[name='template']" (rootNode) { | ||
| templateLocation = templateLocation || rootNode.loc.start |
There was a problem hiding this comment.
Please remove the templateLocation variable.
Yep, code updated, I forgot that one 👍 |
|
Hey guys, How to lint <script setup>
// import Layout from '@/components/common/Layout.vue';
import { RouterView } from 'vue-router';
import '@/stores';
</script>
<template>
<Layout>
<RouterView />
</Layout>
</template> 'vue/no-unregistered-components': [
'error',
{
ignorePatterns: ['van(\\-\\w+)+', 'el(\\-\\w+)+'],
},
], |
Closes #1112
Inspired by rules/no-unused-components so thanks to Michał Sajnóg.
What are your thoughts @ota-meshi? let me know if this is missing something or you have some concerns, thanks!