Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup and emits to the options checked by the vue/order-in-components rule. #1134

Closed
1 of 4 tasks
ota-meshi opened this issue May 17, 2020 · 3 comments
Closed
1 of 4 tasks

Comments

@ota-meshi
Copy link
Member

Please describe what the rule should do:

The vue/order-in-components rule checks setup and emits options. (setup and emits added in Vue.js 3.x)
The default order for the vue/order-in-components rule is designed according to the style guide.
But, setup and emits are new options added in Vue.js 3.x, and the order is not defined in the style guide.
We first need to define the style guide.

What category should the rule belong to?

  • Enforces code style
  • Warns about a potential error
  • Suggests an alternate way of doing something
  • Other (please specify:)

Provide 2-3 code examples that this rule should warn about:

TODO

Additional context

@ota-meshi
Copy link
Member Author

Lifecycle hooks may also have changed...

@ota-meshi
Copy link
Member Author

We also need to add provide / inject, which already exists from Vue 2.x.

@ota-meshi
Copy link
Member Author

The internal style guide documentation has been updated, so I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant