Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the default order setting of vue/order-in-components rule. #1181

Merged
merged 2 commits into from Jun 6, 2020

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 31, 2020

  • Add options for Vue.js 3.x
    • emits to after props.
    • setup to after emits.
    • beforeUnmount and unmounted to LIFECYCLE_HOOKS.
    • renderTracked and renderTriggered to LIFECYCLE_HOOKS.
  • Add options for Vue.js 2.x
    • provide and inject to after mixins.
    • errorCaptured to LIFECYCLE_HOOKS.
  • Changed the position where vue/require-explicit-emits rule suggests adding emits.

refs #1134

- Add options for Vue.js 3.x
  - `emits` to after `props`.
  - `setup` to after `emits`.
  - `beforeUnmount` and `unmounted` to LIFECYCLE_HOOKS.
  - `renderTracked` and `renderTriggered` to LIFECYCLE_HOOKS.

- Add options for Vue.js 2.x
  - `provide` and `inject` to after `mixins`.
  - `errorCaptured` to LIFECYCLE_HOOKS.
@ota-meshi
Copy link
Member Author

There's no consensus on ordering, but I'd like to alpha release this and see if people accept it.

@ota-meshi ota-meshi merged commit bf7d219 into master Jun 6, 2020
@ota-meshi ota-meshi deleted the update-order-in-components branch June 6, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant