Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools] use ESLint class instead of CLIEngine #1215

Closed
tyankatsu0105 opened this issue Jun 23, 2020 · 4 comments · Fixed by #1216
Closed

[tools] use ESLint class instead of CLIEngine #1215

tyankatsu0105 opened this issue Jun 23, 2020 · 4 comments · Fixed by #1216

Comments

@tyankatsu0105
Copy link
Contributor

Since version 7.0.0, ESLint supports ESLint class instead of CLIEngine class.
eslint/eslint#12939
eslint/rfcs#40

So, if it's possible, let's use ESLint class!
@ota-meshi
Copy link
Member

Thank you for your suggestions!

But we will still support ESLint v6. So we may not need to replace it now.

However, I think it is possible to replace the CLIEngine of scripts that are not related to test cases at now.

@tyankatsu0105
Copy link
Contributor Author

@ota-meshi
Oh sorry.
I overlooked supports version.
Umm...
Can I replace around tools?

@ota-meshi
Copy link
Member

Can I replace around tools?

Yes. I think we can replace it.

@tyankatsu0105
Copy link
Contributor Author

Great! Thanks for checking.
I will send PR😉

@tyankatsu0105 tyankatsu0105 changed the title use ESLint class instead of CLIEngine [tools] use ESLint class instead of CLIEngine Jun 23, 2020
@tyankatsu0105 tyankatsu0105 mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tools): use ESLint class tyankatsu0105/eslint-plugin-vue
2 participants
@ota-meshi @tyankatsu0105