- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add vue/no-multiple-objects-in-class
rule
#1218
feat: Add vue/no-multiple-objects-in-class
rule
#1218
Conversation
vue/no-multiple-object-in-class
vue/no-multiple-objects-in-class
vue/no-multiple-objects-in-class
vue/no-multiple-objects-in-class
rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
Almost looks good to me, but I have only one request.
valid: [ | ||
`<template><div :class="[{'foo': isFoo}]" /></template>`, | ||
`<template><div :class="[{'foo': isFoo, 'bar': isBar}]" /></template>`, | ||
`<template><div v-foo:class="[{'foo': isFoo}, {'bar': isBar}]" /></template>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule don't take into other thanv-bind:class
consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you!
close #1093
I'm not sure of the rule name, so any better suggestions are welcome.
This PR adds vue/no-multiple-objects-in-class rule.