Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v-for-delimiter-style rule #1267

Merged
merged 3 commits into from Jul 31, 2020
Merged

Add v-for-delimiter-style rule #1267

merged 3 commits into from Jul 31, 2020

Conversation

FloEdelmann
Copy link
Member

Closes #1228.

ota-meshi
ota-meshi requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I have two change requests.

lib/rules/v-for-delimiter-style.js Outdated Show resolved Hide resolved
tests/lib/rules/v-for-delimiter-style.js Outdated Show resolved Hide resolved
ota-meshi
ota-meshi approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thank you!

@ota-meshi ota-meshi merged commit 61c62e9 into vuejs:master Jul 31, 2020
@FloEdelmann FloEdelmann deleted the v-for-delimiter-style branch July 31, 2020 11:59
@FloEdelmann FloEdelmann mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
new rule proposition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: v-for-delimiter-style
2 participants
@FloEdelmann @ota-meshi