Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed false positives for v-bind="object" syntax in vue/attributes-order rule #1391

Merged
merged 1 commit into from Dec 27, 2020

Conversation

ota-meshi
Copy link
Member

This PR fixes false positives for v-bind="object" syntax in vue/attributes-order rule.

For example, there were the following false positives:

<template>
  <div
    v-bind="object"
    id="x"> <!-- Attribute "id" should go before "v-bind". -->
  </div>
</template>

However, in Vue3, changing this order will change the behavior.

v-bind="object" changes the rule to report an error only if it's okay to change the order.

@ota-meshi ota-meshi added the bug label Dec 26, 2020
@ota-meshi ota-meshi merged commit 543361b into master Dec 27, 2020
@ota-meshi ota-meshi deleted the attributes-order-v-bind branch December 27, 2020 02:56
@danyadev
Copy link
Contributor

danyadev commented Jan 16, 2021

@ota-meshi I didn't understand a little how it works...

in the config, I did not define the attributes-order property, so the default settings are used.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants