Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make no-ref-as-operand fixable close #1394 #1396

Merged
merged 2 commits into from Jan 3, 2021
Merged

Make no-ref-as-operand fixable close #1394 #1396

merged 2 commits into from Jan 3, 2021

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Dec 29, 2020 •
edited

This PR makes vue/no-ref-as-operand fixable fixable. close #1394
The auto fix adds .value after the Ref value where it is needed.

ota-meshi
ota-meshi requested changes Jan 2, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
I have one request.

lib/rules/no-ref-as-operand.js Outdated Show resolved Hide resolved
@sapphi-red @ota-meshi
dont use array for returning a single fix data
5fa9ea3 
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
@sapphi-red
Copy link
Contributor Author

Thank you for reviewing! I fixed it.

ota-meshi
ota-meshi approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 42a543d into vuejs:master Jan 3, 2021
@sapphi-red sapphi-red deleted the no-ref-as-operand--fixable branch January 21, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make vue/no-ref-as-operand fixable
2 participants
@sapphi-red @ota-meshi