Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/next-tick-style rule #1400

Merged
merged 17 commits into from Jan 21, 2021
Merged

Add vue/next-tick-style rule #1400

merged 17 commits into from Jan 21, 2021

Conversation

FloEdelmann
Copy link
Member

Closes #1318.

Before reviewing, please have a look at #1399. Does it make sense to merge these two rules into one? If so, I'll try to implement that.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I have some requests.

docs/rules/next-tick-style.md Outdated Show resolved Hide resolved
docs/rules/next-tick-style.md Outdated Show resolved Hide resolved
lib/rules/next-tick-style.js Outdated Show resolved Hide resolved
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@ota-meshi ota-meshi merged commit ec2dc79 into vuejs:master Jan 21, 2021
@FloEdelmann FloEdelmann deleted the next-tick-style branch January 21, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: vue/next-tick-style
2 participants