Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add vue/no-invalid-model-keys rule #1466

Merged
merged 17 commits into from Apr 12, 2021

Conversation

Alex-Sokolov
Copy link
Contributor

@Alex-Sokolov Alex-Sokolov commented Mar 25, 2021

This PR adds the rule vue/no-invalid-model-keys which check model prop keys

REF: #824

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
The source code looks good, but I have some change requests.

docs/rules/no-invalid-model-keys.md Outdated Show resolved Hide resolved
docs/rules/no-invalid-model-keys.md Outdated Show resolved Hide resolved
docs/rules/no-invalid-model-keys.md Outdated Show resolved Hide resolved
docs/rules/no-invalid-model-keys.md Outdated Show resolved Hide resolved
lib/rules/no-invalid-model-keys.js Outdated Show resolved Hide resolved
lib/rules/no-invalid-model-keys.js Outdated Show resolved Hide resolved
docs/rules/no-invalid-model-keys.md Outdated Show resolved Hide resolved
Alex-Sokolov and others added 12 commits March 31, 2021 10:41
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
@Alex-Sokolov
Copy link
Contributor Author

@ota-meshi thanks for review and suggestions! Could you check again please?

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@ota-meshi ota-meshi merged commit 084bfe3 into vuejs:master Apr 12, 2021
@Alex-Sokolov Alex-Sokolov deleted the new-rule-no-invalid-model-keys branch April 12, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants