Add vue/no-restricted-class rule #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
requested changes
Sep 28, 2021
|
Thanks @ota-meshi for the help! Very helpful points -- I've applied your suggestions, and ensured that we handle array syntax. |
ota-meshi
requested changes
Sep 29, 2021
| yield* extractClassNames(node.left, true) | ||
| yield* extractClassNames(node.right, true) | ||
| return | ||
| } |
There was a problem hiding this comment.
I made a mistake in the if statement. We need to add the following:
Suggested change
| } | |
| } | |
| if (textOnly) { | |
| return | |
| } |
<template><div :class="''+{forbidden:true}">Content</div></template> is actually drawn as <div class="[object Object]">Content</div>.
There was a problem hiding this comment.
Thank you; fixed -- and added a test case.
lib/rules/no-restricted-class.js
Outdated
Comment on lines
94
to
96
| if (!textOnly) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!textOnly) { | |
| return | |
| } |
ota-meshi
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to refactor the rule somewhat from my original implementation to make it work with Typescript. This made it a bit harder to read, so any suggestions for improving that are welcome.