Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-word-component-names rule #1661

Merged
merged 2 commits into from Oct 18, 2021
Merged

Add multi-word-component-names rule #1661

merged 2 commits into from Oct 18, 2021

Conversation

csordasmarton
Copy link
Contributor

Closes #245

@csordasmarton
Copy link
Contributor Author

Netlify gives me the following error: Error: Cannot find module 'eslint'. Can someone help me to fix this problem and also to review my PR?

ota-meshi
ota-meshi requested changes Oct 17, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!!!
I think the implementation of the rule is mostly good. However, I have some change requests.

lib/rules/multi-word-component-names.js Outdated Show resolved Hide resolved
docs/rules/multi-word-component-names.md Outdated Show resolved Hide resolved
docs/rules/multi-word-component-names.md Outdated Show resolved Hide resolved
docs/rules/multi-word-component-names.md Outdated Show resolved Hide resolved
docs/rules/multi-word-component-names.md Show resolved Hide resolved
lib/rules/multi-word-component-names.js Outdated Show resolved Hide resolved
@csordasmarton
Copy link
Contributor Author

@ota-meshi Thanks for your comments 😊 I think I have fixed all of your comments.

ota-meshi
ota-meshi approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@ota-meshi ota-meshi merged commit a74dd59 into vuejs:master Oct 18, 2021
@charles-allen charles-allen mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: multi-word-component-names
2 participants
@csordasmarton @ota-meshi