Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-deprecated-router-link-tag-prop rule #1663

Merged

Conversation

csordasmarton
Copy link
Contributor

Closes #1306

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I have some change requests.

lib/rules/no-deprecated-router-link-tag-prop.js Outdated Show resolved Hide resolved
- Use helper functions from utils to get attributes for nodes.
- Add more test cases.
- Handle both kebab-case and PascalCase version of components.
@csordasmarton
Copy link
Contributor Author

@ota-meshi Good catch, I fixed your comments and thanks for your help 😊

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit b28867d into vuejs:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal: vue/no-deprecated-router-link-tag-prop
2 participants