Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Nuxt.js's asyncData in various rules #1679

Merged
merged 6 commits into from Oct 29, 2021
Merged

Support Nuxt.js's asyncData in various rules #1679

merged 6 commits into from Oct 29, 2021

Conversation

FloEdelmann
Copy link
Member

Fixes #1668.

ota-meshi
ota-meshi requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
This change looks good. Could you format and push it?

ota-meshi
ota-meshi approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 0437972 into vuejs:master Oct 29, 2021
@FloEdelmann FloEdelmann deleted the asyncdata branch October 29, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/no-undef-properties does not respect Nuxt's asyncData
2 participants
@FloEdelmann @ota-meshi