Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report $set and $nextTick in computed properties #1750

Merged
merged 3 commits into from Jan 6, 2022
Merged

Report $set and $nextTick in computed properties #1750

merged 3 commits into from Jan 6, 2022

Conversation

FloEdelmann
Copy link
Member

Fixes #1744.

@FloEdelmann FloEdelmann changed the title Report set/nextTick in vue/no-side-effects-in-computed-properties Report $set and $nextTick in computed properties Jan 5, 2022
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit e7b77aa into vuejs:master Jan 6, 2022
@FloEdelmann FloEdelmann deleted the 1744-no-side-effects-in-computed-properties branch January 6, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-side-effects-in-computed-properties does not report errors for this.$set or this.$nextTick
2 participants