Fix false positive for unknown emits definition in vue/require-explicit-emits rule
#1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
reviewed
Jan 7, 2022
lib/utils/index.js
Outdated
| } | ||
|
|
||
| return getComponentPropsFromDefine(propsNode.value) | ||
| return getComponentPropsFromOptions(componentObject) |
There was a problem hiding this comment.
This is the only statement in the getComponentProps function now. Can we rename it to getComponentPropsFromOptions (also everywhere it is used) and only export a reference to getComponentPropsFromOptions?
module.exports = {
// …
getComponentPropsFromOptions,
// …
}
function getComponentPropsFromOptions(…) { … }Or rename getComponentPropsFromOptions to getComponentProps and export only a reference to it?
module.exports = {
// …
getComponentProps,
// …
}
function getComponentProps(…) { … }Or don't rename anything, but still only export a function reference?
module.exports = {
// …
getComponentProps: getComponentPropsFromOptions,
// …
}
function getComponentPropsFromOptions(…) { … }There was a problem hiding this comment.
Thank you for your review! I changed method name and to use the shorthand property.
However, for backward compatibility, it also defines a method with the old name.
lib/utils/index.js
Outdated
| } | ||
|
|
||
| return getComponentEmitsFromDefine(emitsNode.value) | ||
| return getComponentEmitsFromOptions(componentObject) |
FloEdelmann
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1748