Auto-fix for vue/component-tags-order #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
approved these changes
Mar 2, 2022
FloEdelmann
approved these changes
Mar 2, 2022
|
Wait, there's something I can't determine here. If there is a comment right above the element start tag, should we move the comment too? For example, <style></style>
<!-- this is a comment -->
<script>
</script>Should we move the comment together with the <style></style>
<!-- eslint-disable-next-line vue/multi-word-component-names -->
<script>
export default {
name: 'Comp'
}
</script>@FloEdelmann @ota-meshi Would you have a look at this plz? |
|
Moving a comment together with the following block would be nice, regardless of whether it is an eslint-disable comment or not. However, I don't think that this would be merge-blocking for me. |
ota-meshi
requested changes
Mar 3, 2022
Apply suggestions from code review Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463.
This PR reflects the comments from @ota-meshi in #1512 . It yields a fix for each reported error, so eslint-disable comments work normally. Added a test case for eslint-disable comment.