Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefer-prop-type-boolean-first rule #1822

Merged
merged 6 commits into from Mar 23, 2022
Merged

Add prefer-prop-type-boolean-first rule #1822

merged 6 commits into from Mar 23, 2022

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Mar 21, 2022

Close #1797 .

FloEdelmann
FloEdelmann requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks really nice! I've commented a few small suggestions.

docs/rules/prefer-prop-type-boolean-first.md Outdated Show resolved Hide resolved
lib/rules/prefer-prop-type-boolean-first.js Outdated Show resolved Hide resolved
tests/lib/rules/prefer-prop-type-boolean-first.js Outdated Show resolved Hide resolved
tests/lib/rules/prefer-prop-type-boolean-first.js Show resolved Hide resolved
docs/rules/prefer-prop-type-boolean-first.md Outdated Show resolved Hide resolved
docs/rules/prefer-prop-type-boolean-first.md Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Thanks!

ota-meshi
ota-meshi approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit f5f4f97 into vuejs:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule suggestion: vue/prefer-prop-type-boolean-first
3 participants
@g-plane @FloEdelmann @ota-meshi