Improve usage of postcss-selector-parser #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
commented
Apr 11, 2022
| */ | ||
| let result = null | ||
| while (node) { | ||
| if (node.type === 'combinator') { |
There was a problem hiding this comment.
The component-tags-order rule does not use the combinator, but it does handle the combinator so that it can be used in future changes. It has also been tested.
The CI for pull requests from some forks doesn't seem to work. But I don't know the rules. The settings appear to be set to build pull requests from forks as well. |
Merged
ota-meshi
force-pushed
the
component-tags-order-support-query
branch
from
0b2e7fa
to
6c8cc62
Compare
FloEdelmann
reviewed
Apr 11, 2022
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
FloEdelmann
requested changes
Apr 11, 2022
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
|
Thank you for checking this PR. |
FloEdelmann
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR followup for #1825.
Also, fixing the linting errors. (Circle CI didn't seem to work well 馃)Fixed #1843Also, I made a small change in the documentation.