Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1836 #1844

Merged
merged 2 commits into from Apr 12, 2022
Merged

Fix 1836 #1844

merged 2 commits into from Apr 12, 2022

Conversation

doug-wade
Copy link
Contributor

Addresses #1836

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
But maybe @ota-meshi thinks that some util function needs to be fixed instead of fixing only this rule?

@ota-meshi
Copy link
Member

But maybe @ota-meshi thinks that some util function needs to be fixed instead of fixing only this rule?

I think it's okay to fixing only this rule for now 👍

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit a473a0d into vuejs:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/multi-word-component-names doesn't catch SFCs with setup script?
3 participants