Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new vue/require-prop-comment rule #2019

Merged
merged 28 commits into from Nov 2, 2022
Merged

Add new vue/require-prop-comment rule #2019

merged 28 commits into from Nov 2, 2022

Conversation

czb3279338858
Copy link
Contributor

Fixes #1993

FloEdelmann
FloEdelmann requested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix all comments from #2018

docs/rules/README.md Outdated Show resolved Hide resolved
docs/rules/require-prop-comment.md Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some improvements, that was faster than explaining them. Could you check them please? After that, would you fancy fixing the tests accordingly?

tests/lib/rules/require-prop-comment.js Outdated Show resolved Hide resolved
docs/rules/require-prop-comment.md Show resolved Hide resolved
tests/lib/rules/require-prop-comment.js Outdated Show resolved Hide resolved
ota-meshi
ota-meshi requested changes Oct 30, 2022
View reviewed changes
lib/rules/require-prop-comment.js Outdated Show resolved Hide resolved
lib/rules/require-prop-comment.js Outdated Show resolved Hide resolved
tests/lib/rules/require-prop-comment.js Show resolved Hide resolved
lib/rules/require-prop-comment.js Outdated Show resolved Hide resolved
@czb3279338858
Copy link
Contributor Author

Please fix all comments from #2018
Finished

ota-meshi
ota-meshi approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@czb3279338858

This comment was marked as outdated.

Sign in to view
@FloEdelmann FloEdelmann changed the title Add new vue/require-prop-comment rule Add new vue/require-prop-comment rule Nov 1, 2022
@ota-meshi ota-meshi reopened this Nov 2, 2022
@FloEdelmann
Copy link
Member

@czb3279338858 Why did you force-push and remove my last commit?

@czb3279338858
Copy link
Contributor Author

@FloEdelmann Sorry,i sync fork，and vscode Synchronize changes。The modification may be caused by this operation

@czb3279338858
Copy link
Contributor Author

@FloEdelmann Sorry,i sync fork，and vscode Synchronize changes。The modification may be caused by this operation

@czb3279338858 Why did you force-push and remove my last commit?

During sync fork, all the changes were discarded. At the same time, there were no changes submitted by you in my local area, resulting in loss. so sorry

@ota-meshi ota-meshi merged commit bf5829c into vuejs:master Nov 2, 2022
@FloEdelmann FloEdelmann mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require-prop-comment
3 participants
@czb3279338858 @FloEdelmann @ota-meshi