Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shallowOnly option to vue/no-mutating-props #2135

Merged
merged 6 commits into from May 10, 2023
Merged

Add shallowOnly option to vue/no-mutating-props #2135

merged 6 commits into from May 10, 2023

Conversation

FlareZh
Copy link
Contributor

@FlareZh FlareZh commented Apr 20, 2023 •
edited

Ref #1371

ota-meshi
ota-meshi requested changes Apr 30, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I have change request.

docs/rules/no-mutating-props.md Outdated Show resolved Hide resolved
lib/utils/index.js Outdated Show resolved Hide resolved
@ota-meshi ota-meshi linked an issue Apr 30, 2023 that may be closed by this pull request
vue/no-mutating-props option: {"propProps": false} #1371
Closed
@FlareZh FlareZh changed the title Add propProps option to vue/no-mutating-props (#1371) Add shallowOnly option to vue/no-mutating-props (#1371) May 8, 2023
@FloEdelmann FloEdelmann changed the title Add shallowOnly option to vue/no-mutating-props (#1371) Add shallowOnly option to vue/no-mutating-props May 8, 2023
ota-meshi
ota-meshi requested changes May 9, 2023
View reviewed changes
lib/rules/no-mutating-props.js Outdated Show resolved Hide resolved
lib/rules/no-mutating-props.js Outdated Show resolved Hide resolved
ota-meshi
ota-meshi approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thank you!

FloEdelmann
FloEdelmann approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@FloEdelmann FloEdelmann merged commit 3cbb1b3 into vuejs:master May 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/no-mutating-props option: {"propProps": false}
3 participants
@FlareZh @FloEdelmann @ota-meshi