Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoDeprecatedRouterLinkTagPropRule schema is missing additionalProperties #2137

Closed
Dimava opened this issue Apr 22, 2023 · 1 comment · Fixed by #2177
Closed

NoDeprecatedRouterLinkTagPropRule schema is missing additionalProperties #2137

Dimava opened this issue Apr 22, 2023 · 1 comment · Fixed by #2177

Comments

@Dimava
Copy link

Dimava commented Apr 22, 2023

schema: [
{
type: 'object',
properties: {
components: {
type: 'array',
items: {
type: 'string'
},
uniqueItems: true,
minItems: 1
}
}
}
],

This rule is one of the rules causing type inconsistency for eslint-define-config
eslint-types/eslint-define-config#189

Please fix this by adding either additionalProperties: false or additionalProperties: { type: recordValueType }

export interface NoDeprecatedRouterLinkTagPropRule {
  /**
   * Disallow using deprecated `tag` property on `RouterLink` (in Vue.js 3.0.0+).
   *
   * @see [no-deprecated-router-link-tag-prop](https://eslint.vuejs.org/rules/no-deprecated-router-link-tag-prop.html)
   */
  'vue/no-deprecated-router-link-tag-prop': Rule<
    [
      RuleLevel,
      {
        /**
         * @minItems 1
         */
        components?: [string, ...string[]];
        [k: string]: any; // <-- UNWANTED: additionalProperties
      },
    ]
  >;
}
@FloEdelmann
Copy link
Member

Thanks for letting us know. It should be additionalProperties: false. A PR is welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants