Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processor): export meta object for flat config #2145

Merged
merged 2 commits into from May 7, 2023

Conversation

TatsuyaYamamoto
Copy link
Contributor

Related issue: nothing
Related PR: vuejs/vue-eslint-parser#190

This PR’s purpose is to support ESLint flat config.

Loading eslint-plugin-vue in flat config, ESLint check processor’s name and version in meta object.
https://github.com/eslint/eslint/blob/main/lib/config/flat-config-array.js#L220
https://github.com/eslint/eslint/blob/main/lib/config/flat-config-array.js#L45-L76

@TatsuyaYamamoto
Copy link
Contributor Author

TatsuyaYamamoto commented May 6, 2023

it looks like a lint error unrelated to this PR diff

https://app.circleci.com/pipelines/github/vuejs/eslint-plugin-vue/2007/workflows/2423c30e-c5b2-4353-ac13-fe741fb9f461/jobs/14466

> eslint-plugin-vue@9.11.0 lint /root/project
> eslint . --rulesdir eslint-internal-rules && markdownlint "**/*.md"


Oops! Something went wrong! :(

ESLint: 8.40.0

TypeError: Cannot read property 'getAllComments' of undefined
Occurred while linting /root/project/.eslintrc.js:1
Rule: "unicorn/expiring-todo-comments"
    at Object.Program

@TatsuyaYamamoto
Copy link
Contributor Author

If installed ESLint v8.40, it seems to need to install eslint-plugin-unicorn v46.0.1 or higher.
sindresorhus/eslint-plugin-unicorn#2076

@TatsuyaYamamoto
Copy link
Contributor Author

Added PR #2146

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I think we can merge them despite the failing tests.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit c65c3a9 into vuejs:master May 7, 2023
14 checks passed
@TatsuyaYamamoto TatsuyaYamamoto deleted the processor-meta-object branch May 7, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants