Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for defineOptions and defineSlots to vue/define-macros-order rule #2154

Merged
merged 4 commits into from May 12, 2023

Conversation

ota-meshi
Copy link
Member

This PR adds support for defineOptions and defineSlots in vue/define-macros-order rule. (Default behavior is unchanged.)

This PR also includes changes that make utils.defineScriptSetupVisitor visit defineSlots and defineOptions.

@ota-meshi ota-meshi linked an issue May 12, 2023 that may be closed by this pull request
@ota-meshi ota-meshi changed the title Add support for defineOptions and defineSlots in vue/define-macros-order rule Add support for defineOptions and defineSlots to vue/define-macros-order rule May 12, 2023
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM!

@ota-meshi ota-meshi merged commit 012e2df into master May 12, 2023
14 checks passed
@ota-meshi ota-meshi deleted the define-macros-order branch May 12, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for defineSlots and slots option
2 participants