Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue/valid-define-options rule #2165

Merged
merged 4 commits into from May 13, 2023
Merged

Add vue/valid-define-options rule #2165

merged 4 commits into from May 13, 2023

Conversation

ota-meshi
Copy link
Member

This PR adds vue/valid-define-options rule that checks whether defineOptions compiler macro is valid.

@ota-meshi ota-meshi mentioned this pull request May 13, 2023
Closed
FloEdelmann
FloEdelmann approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one little wording issue, this looks good to me :)

lib/rules/valid-define-options.js Outdated Show resolved Hide resolved
ota-meshi and others added 3 commits May 13, 2023 22:46
@ota-meshi @FloEdelmann
Update lib/rules/valid-define-options.js
9d5e26c 
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
@ota-meshi
fix sentence
5a70e7b
@ota-meshi
format
043a619
@ota-meshi ota-meshi linked an issue May 13, 2023 that may be closed by this pull request
Support for defineOptions #2118
Closed
@ota-meshi ota-meshi merged commit 2ee0f4b into master May 13, 2023
14 checks passed
@ota-meshi ota-meshi deleted the valid-define-options branch May 13, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for defineOptions
2 participants
@ota-meshi @FloEdelmann