Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive for unknown prop in vue/no-undef-properties rule #2186

Merged
merged 4 commits into from May 22, 2023

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 22, 2023

fixes #2183


This PR fixes unknown properties to be ignored from check when encountered.
There was a false positive if the user did not enable type information for rules in the ESLint configuration and defined the prop type externally.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from two minor wording mistakes, this looks good to me :)

lib/rules/no-undef-properties.js Outdated Show resolved Hide resolved
lib/rules/no-undef-properties.js Outdated Show resolved Hide resolved
@ota-meshi ota-meshi merged commit d93f2c6 into master May 22, 2023
14 checks passed
@ota-meshi ota-meshi deleted the issue2183 branch May 22, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3.3 throws vue/no-undef-properties for types exported from external files
2 participants