Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for toRef props in vue/no-dupe-keys rule #2189

Merged
merged 3 commits into from May 26, 2023
Merged

Fix false positives for toRef props in vue/no-dupe-keys rule #2189

merged 3 commits into from May 26, 2023

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 24, 2023 •
edited by FloEdelmann

@FloEdelmann FloEdelmann mentioned this pull request May 24, 2023
Closed
@ota-meshi ota-meshi linked an issue May 26, 2023 that may be closed by this pull request
vue/no-dupe-keys tips Duplicated key #2192
Closed
@FloEdelmann FloEdelmann mentioned this pull request May 26, 2023
Closed
FloEdelmann
FloEdelmann reviewed May 26, 2023
View reviewed changes
lib/rules/no-dupe-keys.js Show resolved Hide resolved
lib/rules/no-dupe-keys.js Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now :)

@ota-meshi ota-meshi merged commit 25fcb9b into master May 26, 2023
14 checks passed
@ota-meshi ota-meshi deleted the fix-no-dupe-keys branch May 26, 2023 08:00
@N-Silbernagel N-Silbernagel mentioned this pull request May 30, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/no-dupe-keys tips Duplicated key Extend vue/no-dupe-keys to support <script setup>
2 participants
@ota-meshi @FloEdelmann