Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue/no-console rule #2194

Merged
merged 6 commits into from May 30, 2023
Merged

Add vue/no-console rule #2194

merged 6 commits into from May 30, 2023

Conversation

ItMaga
Copy link
Contributor

@ItMaga ItMaga commented May 27, 2023

Closes #2155

@ItMaga ItMaga changed the title Add 'vue/no-console` rule Add vue/no-console rule May 27, 2023
ota-meshi
ota-meshi requested changes May 28, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
Could you please add test cases to check if the rule works?
Forget this comment.
I saw and commented on the wrong diff.

ota-meshi
ota-meshi requested changes May 28, 2023
View reviewed changes
tests/lib/rules/no-console.js Outdated Show resolved Hide resolved
@ItMaga ItMaga requested a review from ota-meshi May 28, 2023 12:59
ota-meshi
ota-meshi reviewed May 28, 2023
View reviewed changes
docs/rules/no-console.md Outdated Show resolved Hide resolved
ota-meshi
ota-meshi approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

FloEdelmann
FloEdelmann approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 🙂

@ota-meshi ota-meshi merged commit 13167ed into vuejs:master May 30, 2023
14 checks passed
@FloEdelmann FloEdelmann mentioned this pull request Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Rule] vue/no-console
3 participants
@ItMaga @FloEdelmann @ota-meshi