Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue/require-macro-variable-name rule #2198

Merged
merged 4 commits into from Jun 1, 2023
Merged

Add vue/require-macro-variable-name rule #2198

merged 4 commits into from Jun 1, 2023

Conversation

ItMaga
Copy link
Contributor

@ItMaga ItMaga commented May 30, 2023

Closes #2188

FloEdelmann
FloEdelmann approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect! Thanks for the contribution! ✨

ota-meshi
ota-meshi requested changes May 31, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but could you add one test case and change it to work if it doesn't work?

tests/lib/rules/require-macro-variable-name.js Show resolved Hide resolved
@ItMaga ItMaga requested a review from ota-meshi May 31, 2023 20:16
ota-meshi
ota-meshi approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit d815a48 into vuejs:master Jun 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule vue/require-macro-variable-name
3 participants
@ItMaga @FloEdelmann @ota-meshi