Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue/require-typed-ref rule #2204

Merged
merged 18 commits into from Jun 9, 2023
Merged

Add vue/require-typed-ref rule #2204

merged 18 commits into from Jun 9, 2023

Conversation

Demivan
Copy link
Contributor

@Demivan Demivan commented Jun 2, 2023

Closes #2105

@Demivan Demivan mentioned this pull request Jun 2, 2023
Closed
FloEdelmann
FloEdelmann requested changes Jun 2, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Please see a few remarks below.

docs/rules/require-typed-ref.md Outdated Show resolved Hide resolved
lib/rules/require-typed-ref.js Outdated Show resolved Hide resolved
docs/rules/require-typed-ref.md Outdated Show resolved Hide resolved
tests/lib/rules/require-typed-ref.js Show resolved Hide resolved
@Demivan Demivan requested a review from FloEdelmann June 2, 2023 12:08
FloEdelmann
FloEdelmann approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me now 🙂

tests/lib/rules/require-typed-ref.js Outdated Show resolved Hide resolved
tests/lib/rules/require-typed-ref.js Outdated Show resolved Hide resolved
@Demivan @FloEdelmann
Apply suggestions from code review
129916f 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@FloEdelmann FloEdelmann changed the title Add require-typed-ref rule Add vue/require-typed-ref rule Jun 2, 2023
ota-meshi
ota-meshi requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Sorry for the late reply. I've been busy with office work lately.

tests/lib/rules/require-typed-ref.js Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code style suggestions (might violate with our Prettier config, so please check before applying).

lib/rules/require-typed-ref.js Outdated Show resolved Hide resolved
lib/rules/require-typed-ref.js Outdated Show resolved Hide resolved
@Demivan @FloEdelmann
Apply suggestions from code review
36711a8 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
ota-meshi
ota-meshi approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 81ce0ce into vuejs:master Jun 9, 2023
14 checks passed
@FloEdelmann FloEdelmann mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule vue/require-typed-ref: disallow ref() without type parameter or argument
3 participants
@Demivan @FloEdelmann @ota-meshi