Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(valid-v-model): add support for type assertions and non-null expressions #2393

Merged
merged 4 commits into from
Feb 22, 2024
Merged

feat(valid-v-model): add support for type assertions and non-null expressions #2393

merged 4 commits into from
Feb 22, 2024

Conversation

auvred
Copy link
Contributor

@auvred auvred commented Feb 3, 2024

Fixes #2262

Both TSAsExpression and TSNonNullExpression are valid v-model args: vue playground

TSNonNullExpression spec

FloEdelmann
FloEdelmann approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🙂

ota-meshi
ota-meshi requested changes Feb 18, 2024
View reviewed changes
lib/rules/valid-v-model.js Outdated Show resolved Hide resolved
FloEdelmann
FloEdelmann approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding new tests for the fixed behavior!

ota-meshi
ota-meshi approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 1e12806 into vuejs:master Feb 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule "vue/valid-v-model" is conflicted with typed value in template
3 participants
@auvred @FloEdelmann @ota-meshi