Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Proposal: vue/no-mutating-computed #2413

Open
ThomasKientz opened this issue Feb 29, 2024 · 0 comments
Open

Rule Proposal: vue/no-mutating-computed #2413

ThomasKientz opened this issue Feb 29, 2024 · 0 comments

Comments

@ThomasKientz
Copy link

Please describe what the rule should do:
Prevent mutating a computed without setter.

What category should the rule belong to?

[ ] Enforces code style (layout)
[x] Warns about a potential error (problem)
[ ] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule should warn about:

<!-- ✗ BAD -->
<script>
export default {
  data: () => ({
    msg: 'foo'
  }),
  computed: {
    foo() {
      return msg
    }
  },
  methods: {
    test() {
      this.foo = 'bar' // <----- no-mutating-computed
    }
  }
}
</script>
<!-- ✓ GOOD -->
<script>
export default {
  data: () => ({
    msg: 'foo'
  }),
  computed: {
    foo:{
      get() {
        return this.msg
      },
      set(newValue) {
       this.msg = newValue
    }
  },
  methods: {
    test() {
      this.foo = 'bar'
    }
  }
}
</script>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant