⭐️New: Add vue/no-static-inline-styles rule #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
force-pushed
the
add-rule/no-static-inline-styles
branch
from
1d966df
to
6483687
Compare
|
Thank you so much for this PR!! |
| } | ||
| if (!context.options[0] || !context.options[0].allowBinding) { | ||
| visitor[ | ||
| "VAttribute[directive=true][key.name.name='bind'][key.argument.name='style']" |
There was a problem hiding this comment.
Should this be [key.name='bind'][key.argument='style'] ?
There was a problem hiding this comment.
After #807, AST has been changed a bit to support dynamic argument.
There was a problem hiding this comment.
Ah of course. Thank you for the explanation.
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
vue/no-static-inline-stylesrule.vue/no-static-inline-stylesrule reports the static inline style given to the element.We recommend moving the reported inline styles to the
<style>element.Close #826