Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static-class-names-order rule #886

Merged
merged 8 commits into from Dec 26, 2019
Merged

static-class-names-order rule #886

merged 8 commits into from Dec 26, 2019

Conversation

mchmurski-rms
Copy link
Contributor

@mchmurski-rms mchmurski-rms force-pushed the master branch 3 times, most recently from 473d5bf to 2889457 Compare May 2, 2019 08:55
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I have some requests.

lib/rules/class-order.js Outdated Show resolved Hide resolved
tests/lib/rules/class-order.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
docs/rules/class-order.md Outdated Show resolved Hide resolved
@mchmurski-rms mchmurski-rms changed the title class-order rule static-class-names-order rule Nov 11, 2019
@mchmurski-rms
Copy link
Contributor Author

@ota-meshi thanks, this should be ready for review

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the this change! I commented only one.

docs/rules/static-class-names-order.md Outdated Show resolved Hide resolved
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@ota-meshi ota-meshi merged commit a2865e4 into vuejs:master Dec 26, 2019
@ota-meshi ota-meshi mentioned this pull request Dec 26, 2019
4 tasks
@vue-bot
Copy link

vue-bot commented Dec 26, 2019

Hey @mchmurski-rms, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants