From d9b87002f4284886e7dad067ad6e6b3e9a40d7a1 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Fri, 29 Oct 2021 12:46:29 +0900
Subject: [PATCH] Fix false positives for arrow return in `vue/valid-next-tick`
 rule

---
 lib/rules/valid-next-tick.js       |  7 +++++++
 tests/lib/rules/valid-next-tick.js | 16 ++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/lib/rules/valid-next-tick.js b/lib/rules/valid-next-tick.js
index 59bfd554e..ed5137f8c 100644
--- a/lib/rules/valid-next-tick.js
+++ b/lib/rules/valid-next-tick.js
@@ -76,6 +76,13 @@ function isAwaitedPromise(callExpression) {
     // cases like `return nextTick()`
     return true
   }
+  if (
+    callExpression.parent.type === 'ArrowFunctionExpression' &&
+    callExpression.parent.body === callExpression
+  ) {
+    // cases like `() => nextTick()`
+    return true
+  }
 
   if (
     callExpression.parent.type === 'MemberExpression' &&
diff --git a/tests/lib/rules/valid-next-tick.js b/tests/lib/rules/valid-next-tick.js
index 220e43417..a2ac636fb 100644
--- a/tests/lib/rules/valid-next-tick.js
+++ b/tests/lib/rules/valid-next-tick.js
@@ -113,6 +113,22 @@ tester.run('valid-next-tick', rule, {
           return this.$nextTick();
         }
       }</script>`
+    },
+
+    {
+      filename: 'test.vue',
+      code: `<script>;
+      export default {
+        methods: {
+          fn1 () {
+            return this.$nextTick()
+          },
+          fn2 () {
+            return this.$nextTick()
+              .then(() => this.$nextTick())
+          },
+        }
+      }</script>`
     }
   ],
   invalid: [