Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change presets configs and remove unused internal methods #1848

Merged
merged 8 commits into from May 11, 2022

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Apr 14, 2022

Change Vue 3 presets configs

Change Vue 2 preset configs

Note: The rules marked with * are now included in the plugin:vue/essential config because @vue/composition-api and unplugin-vue2-script-setup add (limited) support for these Vue 3 features in Vue 2. If you don't use those libraries, enabling these rules shouldn't affect you.

Rename rules

Internal changes

Also, remove unused internal methods:

  • getComponentProps util method: use getComponentPropsFromOptions instead.
  • getComponentEmits util method: use getComponentEmitsFromOptions instead.

@FloEdelmann

This comment was marked as resolved.

@ota-meshi

This comment was marked as resolved.

@ota-meshi

This comment was marked as resolved.

@ota-meshi ota-meshi merged commit 186833a into master May 11, 2022
@ota-meshi ota-meshi deleted the update-preset branch May 11, 2022 23:50
n0099 added a commit to n0099/open-tbm that referenced this pull request Dec 18, 2023
…slint-plugin-vue@9.19.2`

* config rule `vue/attributes-order` to re-order attrs
* extends from `@typescript-eslint/(strict|stylistic)-type-checked`
- rules that are already enabled in currently using presets: eslint/eslint#14691, vuejs/eslint-plugin-vue#1848
@ .eslintrc.cjs

* change the type of `ApiUsersQuery.pages` to `CursorPagination`
- unused exported type `Pagination`
@ api/index.d.ts
- no longer count user items in noty @ `<User>`
* sync usages of `paginations/usePaginationButtons.ts` with `<PostsPage>` @ `<UsersPage>`
@ fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants